[LUA] to [CLEO] Engine Failure

09 Mai 2018, 23:58

This is a mod by MyThrillex Engine Failure. I tried to recreate it in GTA3script. Is it right??

Code:

CodeAbrir

SCRIPT_START
{
NOP
GET_PLAYER_CHAR scplayer scplayer
LVAR_INT scplayer health car //DECLARING INT
main:
WAIT 0
IF IS_CHAR_SITTING_IN_ANY_CAR scplayer //Check
GET_CAR_CHAR_IS_USING scplayer car
IF NOT IS_CAR_DEAD car  //Car dead check
AND NOT IS_CAR_UPSIDEDOWN car //Upside Down Car check
AND NOT IS_CAR_ON_FIRE car //Catch fire check
GOTO_IF_FALSE main
GET_CAR_HEALTH car health //Car health
IF
health <= 560
PRINT_STRING_NOW "Radiator ~r~Damaged~r" 1000
ELSE
IF health <= 400
PRINT_STRING_NOW "Enigne Damaged" 2000
ELSE
IF health <= 330
PRINT_STRING_NOW "Engine ~r~Dead~r~" 3000
SET_CAR_ENGINE_BROKEN car TRUE
ENDIF
ENDIF
ENDIF
ENDIF
ENDIF
GOTO main
}
SCRIPT_END

10 Mai 2018, 01:01

GET_PLAYER_CHAR scplayer scplayer
LVAR_INT scplayer health car

You tried to store the player handle to a var that wasn't declared yet (scripts are read from top to bottom), and you didn't use the command properly

.

The right way:

Código: Selecionar tudo

LVAR_INT var

GET_PLAYER_CHAR 0 (var)

Using the code above, you get the player1 handle (which is 0) and then you store it to a previously declared var.

The indentation is all wrong. (actually, you didn't use indentation at all)

WAIT 0
IF IS_CHAR_SITTING_IN_ANY_CAR scplayer
GET_CAR_CHAR_IS_USING scplayer car
IF NOT IS_CAR_DEAD car
AND NOT IS_CAR_UPSIDEDOWN car
AND NOT IS_CAR_ON_FIRE car
GOTO_IF_FALSE main
GET_CAR_HEALTH car health
IF
health <= 560
PRINT_STRING_NOW "Radiator ~r~Damaged~r" 1000
ELSE
IF health <= 400
PRINT_STRING_NOW "Enigne Damaged" 2000
ELSE
IF health <= 330
PRINT_STRING_NOW "Engine ~r~Dead~r~" 3000
SET_CAR_ENGINE_BROKEN car TRUE
ENDIF
ENDIF
ENDIF
ENDIF
ENDIF

Indentantion may not seem so important on tiny codes like that one, but seriously, look at this:

Imagem

Look at the second code. Did you manage to distinguish where each IF is open/closed? I bet you didn't. A code with no indentation is awful and confusing. Not only for those who read your codes, but also for you. If you don't use indentation, you'll easily get lost on your own codes when you make more complex scripts.

Read the tutorials. If you really want to learn CLEO (or any programming language), get in your room, lock up the door, stay away from any social network, don't even think on listening to music, and get ready to spend hours, days, months studying

.

10 Mai 2018, 08:59

O fórum buga a indentação, mas ele também não sabe indentar.

10 Mai 2018, 12:33

u need stop the car when the radiator or engine break :S u only do this in the last

10 Mai 2018, 14:01

HybridTheory escreveu: ↑
10 Mai 2018, 01:01
Read the tutorials. If you really want to learn CLEO (or any programming language), get in your room, lock up the door, stay away from any social network, don't even think on listening to music, and get ready to spend hours, days, months studying .

Thx, I'm just learning it. And u just tried it. Thx for help.

I also understood how to code the scplayet thing. Thx